Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSRC conditions #2487
Support SSRC conditions #2487
Changes from 23 commits
81c90c3
fc7deeb
bd12f0d
43e479e
64c71d7
dd3af1d
14f5339
1754fb5
0283dbf
264c75f
fcbcd6d
ef07c33
9179a0f
816f38a
307ec9d
f87e605
4599ec5
559d8aa
31d6c9a
4e6a1c9
6e86cba
b669472
687daa3
12101f1
89efaa7
d161bd6
9e0bc5d
bdc14d3
0a3408f
347f07b
6e245e2
f7dbf1d
0cab5d1
53c2145
ee675fb
c9701eb
2f2fa2f
fa21a91
caddabe
530ae21
97876df
689c6aa
9c79eea
0202ac7
14fdd8e
117eae9
e99c489
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lahirumaramba I see some interfaces with the RemoteConfig prefix and others without. Is there a guideline for what needs the prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall a reason. Looking at this proposal (go/admin-sdk-remote-config) from 2020 it looks like the types that were added later are missing the prefix.... maybe we weren't strict about the prefix in follow up proposals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just reviewing a change for the REST API and I think what happened is the TS API naming biased toward the REST API. The REST API has nested protos, but TS interfaces can't be nested. The parent protos had more qualified names than the child protos. When we created interfaces to match the protos, we retained the existing names.
I think the guideline we discussed against product prefixes still holds and will help the TS API be more consistent.