-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for creating custom tokens without service account credentials #285
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eb5aae1
Initial framework for signing tokens remotely
hiranya911 877fc17
Separated token generator and verifier
hiranya911 2974090
Unit tests for service acct signer
hiranya911 6ac609b
Added integration test
hiranya911 64bfedd
Changed getAccount() to return a Promise
hiranya911 e4d1b11
Returning a buffer from sign API
hiranya911 9ba16e2
More unit tests
hiranya911 b0a4309
Removing unused config
hiranya911 f8bb726
Merge branch 'master' into hkj-jwt-sign
hiranya911 d2c2b89
Updated test description
hiranya911 20a91fa
Cleaning up imports
hiranya911 d31d971
Updated test to verify metadata server headers
hiranya911 c45ccdf
Merge branch 'master' into hkj-jwt-sign
hiranya911 7e38847
Renamed serviceAccount to serviceAccountId
hiranya911 1063d4a
Merge branch 'master' into hkj-jwt-sign
hiranya911 c6dac08
Using new http API for token generation
hiranya911 55ce947
Added comments and documentation
hiranya911 9d6e50c
Merged with master
hiranya911 41a313a
Updated changelog
hiranya911 c89b96a
Responding to code review feedback
hiranya911 b51a8e3
Updated IAM errorm essages
hiranya911 d396206
Updated error message
hiranya911 7602ed8
Merged with master
hiranya911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this check here and not in
verifySessionCookie
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this one too, and updated the error message in the verifier.