Added hash input order option when importing users #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Jacob, I appreciate your help on this but this needs an internal API review before any code can be committed as you are well aware. We will get back to you when we get confirmation. Thanks! |
|
Sorry for the delay @jwngr. The API review for your proposed Node.js changes is under way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #313.
This PR includes the implementation of a new
hash.inputOrderoption for theimportUsers()auth methods, with the relevant unit and integration tests and type definitions. See the issue for more information and a usage example.Note that all unit tests pass on my local machine and all integration tests except
admin.auth importUsers() successfully imports users with MD5 to Firebase Auth w/ explicit password-first hashpass as well. It is my understanding from the--hash-input-orderdocumentation that it should apply to theMD5algorithm as well. However, this integration test fails although the request being made to the Firebase Auth backend looks correct to me. It would be great if someone from the Firebase Auth team took a look into what is going wrong with that test.