Skip to content

Commit

Permalink
Increase expectation timeout to 25 seconds. (#744)
Browse files Browse the repository at this point in the history
I'm doing this to:
1) Experimentally see if it improves the flakiness we've been seeing in the Query Conformance Tests.
2) Insulate us from the fact that GRPC seems to take a /minimum/ of 10 seconds to reconnect (at least in some cases) after a connection failure.

I've opened b/72864027 to revisit this in the future.
  • Loading branch information
mikelehen authored and wilhuff committed Feb 2, 2018
1 parent 47d81fd commit 13f572e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Firestore/Example/Tests/Util/XCTestCase+Await.mm
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@

#import <Foundation/Foundation.h>

static const double kExpectationWaitSeconds = 10.0;
// TODO(b/72864027): Reduce this to 10 seconds again once we've resolved issues with Query
// Conformance Tests flakiness or gotten answers from GRPC about reconnect delays.
static const double kExpectationWaitSeconds = 25.0;

@implementation XCTestCase (Await)

Expand Down

0 comments on commit 13f572e

Please sign in to comment.