Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify large write batches support #2321

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Verify large write batches support #2321

merged 4 commits into from
Jan 29, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jan 28, 2019

This is a port of the test from firebase/firebase-android-sdk#215. Thankfully, no special handling is required here.

@wilhuff wilhuff requested a review from mikelehen January 28, 2019 22:53
mikelehen
mikelehen approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@wilhuff wilhuff merged commit 2ac7c2f into master Jan 29, 2019
@wilhuff wilhuff deleted the wilhuff/large-write-batches branch January 29, 2019 01:21
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@mikelehen mikelehen

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilhuff @mikelehen @googlebot