Codable firestore #838
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| /** | ||
| * A protocol describing the encodable properties of a DocumentReference. | ||
| * | ||
| * Note: this protocol exists as a workaround for the Swift compiler: if the DocumentReference class was | ||
| * extended directly to conform to Codable, the methods implementing the protcol would be need to be | ||
| * marked required but that can't be done in an extension. Declaring the extension on the protocol | ||
| * sidesteps this issue. | ||
| */ | ||
| fileprivate protocol CodableDocumentReference: Codable {} | ||
|
|
||
| extension CodableDocumentReference { | ||
| public init(from decoder: Decoder) throws { | ||
| throw FirestoreDecodingError.decodingIsNotSupported | ||
| } | ||
|
|
||
| public func encode(to encoder: Encoder) throws { | ||
| throw FirestoreEncodingError.encodingIsNotSupported | ||
| } | ||
| } | ||
|
|
||
| extension DocumentReference: CodableDocumentReference {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // | ||
|
There was a problem hiding this comment. Copyright notice. I realize this isn't super important to you, but this is the only way that Google allows me to continue to work in the open with you, so it's very important to me :-). |
||
| // Errors.swift | ||
| // FirebaseFirestoreSwift | ||
| // | ||
| // Created by Oleksii on 27/02/2018. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| enum FirestoreDecodingError: Error { | ||
| case decodingIsNotSupported | ||
| } | ||
|
|
||
| enum FirestoreEncodingError: Error { | ||
| case encodingIsNotSupported | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| /** | ||
| * A protocol describing the encodable properties of a FirebaseFirestore. | ||
| * | ||
| * Note: this protocol exists as a workaround for the Swift compiler: if the FieldValue class was | ||
| * extended directly to conform to Codable, the methods implementing the protcol would be need to be | ||
| * marked required but that can't be done in an extension. Declaring the extension on the protocol | ||
| * sidesteps this issue. | ||
| */ | ||
| fileprivate protocol CodableFieldValue: Encodable {} | ||
|
|
||
| extension CodableFieldValue { | ||
| public func encode(to encoder: Encoder) throws { | ||
| throw FirestoreEncodingError.encodingIsNotSupported | ||
| } | ||
| } | ||
|
|
||
| extension FieldValue: CodableFieldValue {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base state from which you branched was broken. I've since fixed this, but unfortunately these diffs remain. For all the
.xcschemefiles, make sure your upstream branch is up-to-date and then git checkout the master version of these files and commit them. After pushing you shouldn't see any additions to project files.