Report FirebaseCore version #851
Conversation
I've also added clearing of the library names for tests to avoid the auto found versions on load.
* master: Deflake tests
|
@davidair I thought this was going to be for other libraries, not individual SDKs? Is this special because it's Core? |
|
Run ./scripts/style.sh to fix travis |
|
Has the style script changed recently? It's telling me "Please upgrade to clang-format version 6.", but brew says I'm on the latest version. |
|
You're on High Sierra, right? clang-format on high-sierra is now at 7.0.0 clang-format-2018-01-11.high_sierra.bottle.tar.gz -> This is the same problem I had with swiftformat: High Sierra is now ahead of Sierra in homebrew because they're no longer updating Sierra. |
|
Yep, I'm on High Sierra. I locally skipped the version check for now. |
Firebase/Core/FIROptions.m
Outdated
| NSRange minor = NSMakeRange(1, 2); | ||
| NSRange patch = NSMakeRange(3, 2); | ||
| [FIRApp | ||
| registerLibrary:@"FirebaseCore" |
There was a problem hiding this comment.
Let's change this to "fire-ios" to make it compact and generic (other examples could be fire-unity and fire-cpp)
| + (void)registerLibrary:(nonnull NSString *)library withVersion:(nonnull NSString *)version | ||
| NS_SWIFT_NAME(registerLibrary(_:version:)); | ||
| + (void)registerLibrary:(nonnull NSString *)library | ||
| withVersion:(nonnull NSString *)version NS_SWIFT_NAME(registerLibrary(_:version |
There was a problem hiding this comment.
Unfortunately, clang-format can't handle NS_SWIFT_NAME annotations with more than one colon in them. Even more unfortunately, clang can't handle them when they're split across lines like this. As of now this is a broken build. The fix is to format this function declaration by hand and surround it with clang-format off/on, as done here:
There was a problem hiding this comment.
Thanks for the tip! I was looking at this earlier and wonder what happened. I'll format it manually with the format comments.
Report FirebaseCore version
Adds reporting of the FirebaseCore version as part of the useragent.