Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robot webook #1

Closed
samtstern opened this issue May 16, 2017 · 1 comment
Closed

Add robot webook #1

samtstern opened this issue May 16, 2017 · 1 comment
Assignees
@jshcrowthe

Comments

@samtstern
Copy link
Contributor

URL:
https://us-central1-ossbot-f0cad.cloudfunctions.net/githubWebhook

Content type:
application/json

Secret:
N/A

Select individual events:

  • Issues
  • Pull request
  • Issue comment
@jshcrowthe
Copy link
Contributor

Webhook has been added, once we've validated that it works, we can close this.

jshcrowthe added a commit that referenced this issue Jun 16, 2017
@jshcrowthe
refactor(database): remove old database implementation
5ad3059 
This is part #1 of 4 PR's to migrate database
jshcrowthe added a commit that referenced this issue Jun 20, 2017
@jshcrowthe
refactor(database): remove old database implementation [Part 1/3] (#61)
bbd86c1 
* refactor(database): remove old database implementation

This is part #1 of 4 PR's to migrate database

* refactor(database): remove database build processes
jshcrowthe added a commit that referenced this issue Jun 28, 2017
@jshcrowthe
WIP: review adjustments #1
f108014
jshcrowthe added a commit that referenced this issue Jun 28, 2017
@jshcrowthe
WIP: review adjustments #1
61c8d25
jshcrowthe added a commit that referenced this issue Jun 28, 2017
@jshcrowthe
refactor(database): Add typescript database implementation [Part 2/3] (…
bb80d31 
…#62)

* refactor(database): add typescript implementation

* refactor(database): update build process to include database.ts

All integration tests pass at this point

* refactor(*): refactor environment builds to be based on separate .ts files

* WIP: patch database code in nodeJS

* refactor(database): classes for typescript database implementation (#55)

* refactor(database): classes for typescript database implementation

* refactor(database): requested changes & other improvements

* fix(database): Add missing "typeof" (#74)

https://github.com/firebase/firebase-js-sdk/blob/fd0728138d88c454f8e38a78f35d831d6365070c/src/database/js-client/core/Repo.js#L86

* WIP: fixes from @schmidt-sebastian's review

* WIP: fix: TS Build error

* fix(database): fix issue with missing repo method

* WIP: review adjustments #1

* WIP: review comments #2
jshcrowthe added a commit that referenced this issue Jul 6, 2017
@jshcrowthe
refactor(database): Implement database in Typescript (#72)
a8919cd 
* refactor(database): remove old database implementation [Part 1/3] (#61)

* refactor(database): remove old database implementation

This is part #1 of 4 PR's to migrate database

* refactor(database): remove database build processes

* refactor(database): Add typescript database implementation [Part 2/3] (#62)

* refactor(database): add typescript implementation

* refactor(database): update build process to include database.ts

All integration tests pass at this point

* refactor(*): refactor environment builds to be based on separate .ts files

* WIP: patch database code in nodeJS

* refactor(database): classes for typescript database implementation (#55)

* refactor(database): classes for typescript database implementation

* refactor(database): requested changes & other improvements

* fix(database): Add missing "typeof" (#74)

https://github.com/firebase/firebase-js-sdk/blob/fd0728138d88c454f8e38a78f35d831d6365070c/src/database/js-client/core/Repo.js#L86

* WIP: fixes from @schmidt-sebastian's review

* WIP: fix: TS Build error

* fix(database): fix issue with missing repo method

* WIP: review adjustments #1

* WIP: review comments #2

* WIP: refactor(database): Add migrated test harness [Part 3/3] (#71)

* refactor(database): add typescript implementation

* refactor(database): update build process to include database.ts

All integration tests pass at this point

* refactor(*): refactor environment builds to be based on separate .ts files

* WIP: patch database code in nodeJS

* refactor(database): classes for typescript database implementation (#55)

* refactor(database): classes for typescript database implementation

* refactor(database): requested changes & other improvements

* WIP: add the /tests/config dir to the .gitignore

* WIP: add test harness

* WIP: add query tests

There are some tests that have weird timing issues, and because of the polling nature of the
original implementation, we never caught the issue. These should be resolved when able

* WIP: add database.test.ts

* WIP: add node.test.ts

* WIP: add sortedmap.test.ts

* WIP: add datasnapshot.test.ts

* WIP: add sparsesnapshottree.test.ts

* refactor(database): refactor query.test.ts to better preserve original test meaning

* WIP: add crawler_support.test.ts

* WIP: refactor EventAccumulator.ts for data.test.ts

* WIP: fix issue with query.test.ts

* WIP: add connection.test.ts

* WIP: add info.test.ts

* WIP: add order_by.test.ts

I only migrated some of these tests as there was a dependency on the server for several tests

* WIP: fix several code signature problems, add test files

* WIP: add transaction.test.ts

* WIP: working on the broken npm test command

* WIP: working on fixes

* WIP: remove logging

* WIP: fix node tests

* fix(*): fixing test files and CI integration

* WIP: tEMP: Allow branch builds

* WIP: escape string

* refactor(CI): use ChromeHeadless launcher

* WIP: fixes from review.

* WIP: skip flakey test

* WIP: remove unneeded debugger statement

* WIP: fixing nits

* Prevent using uninitialized array in EventEmitter (#85)

* perf(*): fixing build size output issues

* chore(*): remove unneeded build deps
@buu700 buu700 mentioned this issue Oct 8, 2017
Closed
@MarkChrisLevy MarkChrisLevy mentioned this issue Oct 9, 2017
Closed
@ootpapps ootpapps mentioned this issue Jun 15, 2018
Closed
@samtstern samtstern mentioned this issue Oct 1, 2018
Closed
@sengoontoh sengoontoh mentioned this issue Nov 24, 2018
Closed
@ramen-mukherjee ramen-mukherjee mentioned this issue May 14, 2019
Closed
@schmidt-sebastian schmidt-sebastian mentioned this issue Jun 10, 2019
Merged
ghost pushed a commit that referenced this issue Aug 6, 2019
@wu-hui
addressing comments #1
eeec389
ghost pushed a commit that referenced this issue Aug 7, 2019
port public shutdown to web sdk. (#2045)
80d0846 
* pending firebaseApp change

* [AUTOMATED]: Prettier Code Styling

* Looks to be working.

* browser passes/node fails

* [AUTOMATED]: Prettier Code Styling

* add settings for new instance

* final self review.

* addressing comments #1

* [AUTOMATED]: Prettier Code Styling

* address comments #2
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jshcrowthe jshcrowthe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jshcrowthe @samtstern