Fix e2e notify script again #5911

hsubox76 · 2022-01-21T00:47:55Z

Send version and tag.

changeset-bot · 2022-01-21T00:47:58Z

⚠️ No Changeset found

Latest commit: ff47fdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-01-21T01:07:06Z

Size Report ¹

Affected Products

@firebase/auth-compat
Type Base (67b6dec) Merge (c9f0a46) Diff
browser 20.0 kB 20.1 kB +83 B (+0.4%)
esm5 26.9 kB 26.9 kB +87 B (+0.3%)
main 29.4 kB 29.5 kB +87 B (+0.3%)
module 20.0 kB 20.1 kB +83 B (+0.4%)
@firebase/auth/cordova
Type Base (67b6dec) Merge (c9f0a46) Diff
browser 180 kB 180 kB +28 B (+0.0%)
module 180 kB 180 kB +28 B (+0.0%)
@firebase/auth/internal
Type Base (67b6dec) Merge (c9f0a46) Diff
browser 163 kB 163 kB +12 B (+0.0%)
esm5 212 kB 212 kB +28 B (+0.0%)
main 179 kB 179 kB +28 B (+0.0%)
module 163 kB 163 kB +12 B (+0.0%)
@firebase/auth/react-native
Type Base (67b6dec) Merge (c9f0a46) Diff
browser 163 kB 164 kB +893 B (+0.5%)
module 163 kB 164 kB +893 B (+0.5%)

`@firebase/firestore`

Type	Base (`67b6dec`)	Merge (`c9f0a46`)	Diff
browser	228 kB	228 kB	+734 B (+0.3%)
esm5	285 kB	285 kB	+769 B (+0.3%)
main	453 kB	454 kB	+1.15 kB (+0.3%)
module	228 kB	228 kB	+734 B (+0.3%)
react-native	228 kB	229 kB	+734 B (+0.3%)

`firebase`

Type	Base (`67b6dec`)	Merge (`c9f0a46`)	Diff
firebase-auth-compat.js	123 kB	123 kB	-29 B (-0.0%)
firebase-auth-cordova.js	462 kB	462 kB	+28 B (+0.0%)
firebase-auth-react-native.js	484 kB	486 kB	+1.54 kB (+0.3%)
firebase-auth.js	411 kB	411 kB	+12 B (+0.0%)
firebase-compat.js	753 kB	753 kB	-29 B (-0.0%)
firebase-firestore.js	770 kB	772 kB	+2.18 kB (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/457hSqDGge.html

google-oss-bot · 2022-01-21T01:27:10Z

Size Analysis Report ¹

Affected Products

`@firebase/auth`

`checkActionCode`

Dependency

Type Base (67b6dec) Merge (c9f0a46) Diff

classes

14 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

14 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

+ PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

`getMultiFactorResolver`

Dependency

Type Base (67b6dec) Merge (c9f0a46) Diff

classes

17 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

17 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorResolverImpl
MultiFactorSessionImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserCredentialImpl
UserImpl
UserMetadata

+ PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

`multiFactor`

Dependency

Type Base (67b6dec) Merge (c9f0a46) Diff

classes

16 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

16 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
MultiFactorSessionImpl
MultiFactorUserImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

+ PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

`verifyPasswordResetCode`

Dependency

Type Base (67b6dec) Merge (c9f0a46) Diff

classes

14 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfo
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

14 dependencies

AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
MultiFactorInfoImpl
NetworkTimeout
PersistenceUserManager
PhoneMultiFactorInfoImpl
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

+ PhoneMultiFactorInfoImpl
- PhoneMultiFactorInfo

`@firebase/firestore`

`_setIndexConfiguration`

Size

Type	Base (`67b6dec`)	Merge (`c9f0a46`)	Diff
size	?	20.7 kB	? (?)
size-with-ext-deps	?	69.2 kB	? (?)

Dependency

Type	Base (`67b6dec`)	Merge (`c9f0a46`)	Diff
functions	?	18 dependencies B Ea Fo L M Mh O Oh Su Ta U Ua Vu Zs ga qa st to	?
classes	?	24 dependencies $h Aa C Fa G Gc J Mo Q Ra W X Y Z da dt it mt no tt tu wa xa z	?
variables	?	D N _a _n _t j k vu wn	?
enums	?		?

External Dependency

Module	Base (`67b6dec`)	Merge (`c9f0a46`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError	?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/vJ7z8k3a1w.html

allspain · 2022-01-25T22:57:35Z

scripts/ci/notify-test-result.js

+      testUrl: workflowUrl
+    };
+
+    if (versionOrTag) {


is there a risk that versionOrTag is a truthy non-string? something like 1

I don't think so because the workflow_dispatch input type defaults to string if you don't specify a type and I haven't here:

firebase-js-sdk/.github/workflows/e2e-test.yml

Line 7 in d612d6f

versionOrTag:

allspain · 2022-01-25T22:58:26Z

scripts/ci/notify-test-result.js

+    if (versionOrTag) {
+      // Matches a staging version tag pattern.
+      const match = versionOrTag.match(/^(\d+.\d+.\d+)-\d+$/);
+      if (match) {


Feels like we should do a length check in case match has fewer than expected matches. Accessing 1 directly without validating that it's a valid key seems dangerous

I'm not sure that outcome is possible, if the capturing group doesn't exist in the string, it won't match at all and match will be null. I think the only outcomes are null or an array of length 2. I tried a couple of test strings in the console and can't think of a case that would return non-null but also not have a captured group, let me know if I haven't thought of a case though, regex isn't my strength.

Sounds good I'm ok approving if you are confident

Fix e2e notify script again

f778306

hsubox76 requested a review from allspain as a code owner January 21, 2022 00:47

hsubox76 assigned allspain Jan 24, 2022

Format

ff47fdb

allspain suggested changes Jan 25, 2022

View reviewed changes

allspain assigned hsubox76 and unassigned allspain Jan 25, 2022

hsubox76 assigned allspain and unassigned hsubox76 Jan 26, 2022

allspain approved these changes Jan 31, 2022

View reviewed changes

allspain assigned hsubox76 and unassigned allspain Jan 31, 2022

hsubox76 merged commit b02927e into master Feb 1, 2022

hsubox76 deleted the ch-e2e-notify-2 branch February 1, 2022 00:55

firebase locked and limited conversation to collaborators Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix e2e notify script again #5911

Fix e2e notify script again #5911

hsubox76 commented Jan 21, 2022

changeset-bot bot commented Jan 21, 2022 •

edited

Loading

google-oss-bot commented Jan 21, 2022 •

edited

Loading

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`firebase`

google-oss-bot commented Jan 21, 2022 •

edited

Loading

`@firebase/auth`

`checkActionCode`

`getMultiFactorResolver`

`multiFactor`

`verifyPasswordResetCode`

`@firebase/firestore`

`_setIndexConfiguration`

allspain Jan 25, 2022

hsubox76 Jan 26, 2022

allspain Jan 25, 2022

hsubox76 Jan 26, 2022

allspain Jan 31, 2022

Fix e2e notify script again #5911

Fix e2e notify script again #5911

Conversation

hsubox76 commented Jan 21, 2022

changeset-bot bot commented Jan 21, 2022 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Jan 21, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/auth-compat

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/firestore

firebase

Test Logs

google-oss-bot commented Jan 21, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/auth

checkActionCode

getMultiFactorResolver

multiFactor

verifyPasswordResetCode

@firebase/firestore

_setIndexConfiguration

Test Logs

allspain Jan 25, 2022

Choose a reason for hiding this comment

hsubox76 Jan 26, 2022

Choose a reason for hiding this comment

allspain Jan 25, 2022

Choose a reason for hiding this comment

hsubox76 Jan 26, 2022

Choose a reason for hiding this comment

allspain Jan 31, 2022

Choose a reason for hiding this comment

changeset-bot bot commented Jan 21, 2022 •

edited

Loading

google-oss-bot commented Jan 21, 2022 •

edited

Loading

Size Report ¹

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`firebase`

google-oss-bot commented Jan 21, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`checkActionCode`

`getMultiFactorResolver`

`multiFactor`

`verifyPasswordResetCode`

`@firebase/firestore`

`_setIndexConfiguration`