Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated type of action parameter for DataSnapshot#forEach #6374

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Updated type of action parameter for DataSnapshot#forEach #6374

merged 3 commits into from
Jul 20, 2022

Conversation

rhodgkins
Copy link
Contributor

Fixes #6368

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c353757

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
@firebase/database-types Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rhodgkins rhodgkins marked this pull request as ready for review June 22, 2022 14:26
@rhodgkins rhodgkins requested a review from maneesht June 23, 2022 08:02
@rhodgkins
Copy link
Contributor Author

Thanks @maneesht - the failing API report check, do I need to do anything?

@maneesht
Copy link
Contributor

@rhodgkins - not sure if it will help, but your forked repo is behind, can you update it?

@rhodgkins
Copy link
Contributor Author

@maneesht rebased but no change. According to the logs its missing a token...?

@maneesht
Copy link
Contributor

maneesht commented Jul 4, 2022

Looks like there's an issue related to github actions. We have a fix incoming.

@rhodgkins rhodgkins requested a review from dwyfrequency as a code owner July 7, 2022 18:07
@rhodgkins
Copy link
Contributor Author

Thanks @jsdt - @maneesht I rebased to include your fix (#6409), but still failing unfortunately...

@rhodgkins
Copy link
Contributor Author

@maneesht what else do I need to do to get this merged...? Rather not have this sit here for months as its such a small change!

@maneesht
Copy link
Contributor

@rhodgkins - can you please run yarn build locally, so that it generates the correct md file, and then commit and push the results?

@rhodgkins
Copy link
Contributor Author

@maneesht done, yep that sorted it 🎉 thanks.

@maneesht maneesht merged commit 6583808 into firebase:master Jul 20, 2022
@google-oss-bot google-oss-bot mentioned this pull request Aug 4, 2022
Merged
maneesht added a commit that referenced this pull request Aug 16, 2022
@maneesht
Revert "Updated type of action parameter for DataSnapshot#forEach (#6374
1205b3e 
)"

This reverts commit 6583808.
@maneesht maneesht mentioned this pull request Aug 16, 2022
Merged
maneesht added a commit that referenced this pull request Aug 17, 2022
@maneesht
Revert "Updated type of action parameter for DataSnapshot#forEach" (#…
9f1e3c6 
…6536)

* Revert "Updated type of action parameter for DataSnapshot#forEach (#6374)"

This reverts commit 6583808.
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@maneesht maneesht maneesht approved these changes

@jsdt jsdt jsdt approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@allspain allspain Awaiting requested review from allspain

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rtdb(types): DataSnapshot#forEach - action parameter has null key
4 participants
@rhodgkins @maneesht @jsdt @hsubox76