Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FDC Integration Tests #8703

Merged
merged 34 commits into from
Jan 14, 2025
Merged

Add FDC Integration Tests #8703

merged 34 commits into from
Jan 14, 2025

Conversation

maneesht
Copy link
Contributor

No description provided.

@maneesht maneesht requested review from aashishpatil-g and a team as code owners January 11, 2025 00:05
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 80e4ff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 11, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0755a72) and merge commit (e0a69de).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k0KNILSanD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 11, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (0755a72) and merge commit (e0a69de).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/965u5kJBUF.html

@maneesht maneesht marked this pull request as draft January 13, 2025 19:40
@maneesht maneesht marked this pull request as ready for review January 14, 2025 16:40
hsubox76
hsubox76 reviewed Jan 14, 2025
View reviewed changes
.github/workflows/test-firebase-integration.yml Outdated Show resolved Hide resolved
packages/data-connect/package.json Outdated Show resolved Hide resolved
packages/data-connect/package.json Show resolved Hide resolved
packages/data-connect/package.json Show resolved Hide resolved
yuchenshi
yuchenshi approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for GraphQL readability

dconeybe
dconeybe previously requested changes Jan 14, 2025
View reviewed changes
.github/workflows/test-all.yml Outdated Show resolved Hide resolved
.github/workflows/test-all.yml Outdated Show resolved Hide resolved
.github/workflows/test-all.yml Outdated Show resolved Hide resolved
.github/workflows/test-all.yml Outdated Show resolved Hide resolved
.github/workflows/test-firebase-integration.yml Outdated Show resolved Hide resolved
packages/data-connect/test/dataconnect/dataconnect.yaml Show resolved Hide resolved
packages/data-connect/test/queries.test.ts Outdated Show resolved Hide resolved
packages/data-connect/test/queries.test.ts Show resolved Hide resolved
packages/data-connect/test/util.ts Outdated Show resolved Hide resolved
scripts/emulator-testing/emulators/emulator.ts Outdated Show resolved Hide resolved
hsubox76
hsubox76 previously approved these changes Jan 14, 2025
View reviewed changes
@hsubox76 hsubox76 dismissed their stale review January 14, 2025 23:06

question about workflow

@maneesht maneesht dismissed dconeybe’s stale review January 14, 2025 23:17

Addressed changes

@maneesht maneesht merged commit 21164c2 into main Jan 14, 2025
42 of 50 checks passed
@maneesht maneesht deleted the mtewani/add-integration-test branch January 14, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe dconeybe left review comments

@yuchenshi yuchenshi yuchenshi approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maneesht @google-oss-bot @hsubox76 @yuchenshi @dconeybe @aashishpatil-g