Adds a "firebase" changeset to release PR as needed #8770
+105
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (4e6a5c6) and merge commit (26a94d5).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (4e6a5c6) and merge commit (26a94d5).Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the script that runs when generating a staging release PR (the "Version Packages PR"). This will run on staging. It always added a changeset for
@firebase/appto make sure theSDK_VERSIONconstant got bumped, now we are also checking and adding another changeset forfirebaseif any packages got bumped above apatch(basically,minor, as we are more deliberate about major version bumps).This prevents us from having to give confusing instructions to contributors about when they have to add the "firebase" line to their changeset files, which doesn't seem like something an individual product contributor should have to worry about.