Support v1beta2 indexes API #1014
Conversation
|
@coveralls try again? |
|
Whoops, forgot to assign. @mbleigh feel free to pass off to someone else. |
|
|
||
| // Try to detect use of the old API, warn the users. | ||
| if (spec.indexes[0].collectionId) { | ||
| utils.logBullet( |
There was a problem hiding this comment.
if you print this message, you still want to continue?
There was a problem hiding this comment.
Yes, this is fine for now. Maybe in the future this will be breaking.
src/test/firestore/indexes.spec.ts
Outdated
| { fieldPath: "bar", arrayConfig: "CONTAINS" }, | ||
| ], | ||
| state: API.State.READY, | ||
| } as API.Index; |
There was a problem hiding this comment.
this is definitely a hole in my TS knowledge - is this equivalent? (with no as API.Index)
const apiIndex: API.Index = {...};There was a problem hiding this comment.
Yeah I am not sure what's going on here ... if I do what you suggested it wants me to define all undefined fields as well.
There was a problem hiding this comment.
Oh wait I figured it out.
| @@ -86,7 +87,7 @@ describe("IndexValidation", () => { | |||
| }, | |||
| ], | |||
| }); | |||
| }).to.throw(); | |||
| }).to.throw(FirebaseError, /Must contain exactly one of "order,arrayConfig"/); | |||
There was a problem hiding this comment.
, with no space after? Should that have a space?
There was a problem hiding this comment.
Specifically, in the "Must contain exactly" error message
|
@bkendall yeah you can do a few things: Setup
Tests
|
|
@bkendall should I be waiting for you to do some integration testing here? |
|
Looks like 'upgrade' for old-to-new may have a bug, but the functional testing I did looks good :) |
|
Did a test of deploying an old |
|
huzzah! One last thing: I think you need some specific logs for
|
|
New more better logging:
|
Enables #889
The new indexes API better supports:
Example of pretty-printing index config with some field exemptions:
