Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use total rather than tasks directly #1024

Merged
merged 2 commits into from
Nov 19, 2018
Merged

use total rather than tasks directly #1024

merged 2 commits into from
Nov 19, 2018

Conversation

bkendall
Copy link
Contributor

fixes #1020

Uses stats().total rather than accessing the tasks directly (which no longer has .length)

@bkendall bkendall requested a review from Memeriaj November 19, 2018 17:38
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 19, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.536% when pulling fad004f on bk-fix-percentage into 6ca7eca on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.536% when pulling fad004f on bk-fix-percentage into 6ca7eca on master.

@coveralls
Copy link

coveralls commented Nov 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 59.536% when pulling 3a41345 on bk-fix-percentage into ba83d16 on master.

@bkendall bkendall merged commit ddcaf52 into master Nov 19, 2018
@bkendall bkendall deleted the bk-fix-percentage branch November 19, 2018 17:55
@snyk-bot snyk-bot mentioned this pull request Jul 5, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Memeriaj Memeriaj Memeriaj approved these changes

Assignees

@Memeriaj Memeriaj

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase deploy show wrong percentage number (version 6.1.0)
4 participants
@bkendall @coveralls @Memeriaj @googlebot