Need to fetch the instance before open
#1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2018 16:42
`hosting:site` requires the instance (so that we can populate "<sitename>.firebaseapp.com") but we didn't actually make that requirement explicit, so in some rare cases the instance could be `undefined`.
mbleigh
approved these changes
Nov 30, 2018
mbleigh
reviewed
Nov 30, 2018
1 similar comment
|
@Memeriaj ready to merge? |
|
Yeah, I just didn't want to merge/release it on a Friday. We'll probably release this either later today or early tomorrow, I need to check and see if there are other changes that people want to get in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hosting:siterequires the instance (so that we can populate ".firebaseapp.com") but we didn't actually make that requirement explicit, so in some rare cases the instance could beundefined.