-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bind Host to Functions Emulator inspect argument #1898
Add Bind Host to Functions Emulator inspect argument #1898
Conversation
… binds inspect to the same host the functions emulator is running on
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@collindever thanks for the contribution! Seems like a reasonable change. Could you: a) Take a look at the CLA (you only need to do this once and it covers all Google repos) |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@collindever this is great thank you! Will merge once the CI passes. |
Description
Returns host from the
functionsEmulator::getinfo()
function in case no arg was passed and binds inspect to the same host the functions emulator is running on.This is useful for running on Docker containers where services need to bind to
0.0.0.0
. Issue was also raised in the now archived cloud-functions-emulator repo here googlearchive/cloud-functions-emulator#325 and a similar fix is proposed in their pull request here. googlearchive/cloud-functions-emulator#326Scenarios Tested
With no host passed in the
firebase.json
debug binds to default localhost sample test output for the commandfirebase emulators:start --inspect-functions
Adding the following to firebase.json
and running the same command as above results in ...
Confirmed I could connect to debugger with vsCode and the following
launch.json