Use GCS REST API in place of Firebase Storage REST API. #2343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firebase Storage REST API has a small issue now where file uploads for payloads >100KB reliably fails for some storage buckets.
Here, we change the implementation of
src/gcp/storage.js
to call GCS REST API to upload payloads (it doesn't fail for payloads >100KB).Given that
storage.js
is placed undergcp/
directory, I think the transition to use GCP API vs Firebase API makes sense.Scenarios Tested
Try installing an extension (whose total archive size would exceed 100KB) using its local source:
Without the proposed change, the command fails with a 503 from the Firebase Storage API