Terminate server together with the shell #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the SIGINT handler was only triggered once the repl had been exited. Thus you had to interrupt the process three times before it ended.
|
@op thank you! That bug has been botherinig me for so long. |
|
Funny, I was using this as a feature! With this PR, it doesn't work anymore because the pipe closes the input stream, which causes the termination of the shell 😭 If you can think of a workaround, that would be awesome 🙈 Otherwise we could just revert this PR 😇 (just kidding, I'm grateful for all contributions 😊 ) |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the interrupt handler for
functions:shellwas only triggered once the repl had beenexited. Thus you had to interrupt the process three times before it ended.