-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default timeout is 60s + user define custom timeout per emulator #3482
Default timeout is 60s + user define custom timeout per emulator #3482
Conversation
@@ -311,7 +314,10 @@ function findExportMetadata(importPath: string): ExportMetadata | undefined { | |||
} | |||
} | |||
|
|||
export async function startAll(options: any, showUI: boolean = true): Promise<void> { | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting no-sense...
@mrenrich84 thanks for this! I am in favor of increasing the timeout to 60s but not yet convinced that adding a Would you mind reducing this PR to just the 30s --> 60s change and then we can have a separate discussion about the |
😆 😆 😆 |
@mrenrich84 I think an env var brings up the same discussion. I'd like to think about a few things before moving forward with more configuration:
|
There are few conflicts with the main branch and I'm too lazy to get lost in merge/rebase now 😛 |
Description
Fix #2379
Firestore is failing to start in the hardcoded timeout of 30 secs.
This PR:
Scenarios Tested
GIVEN a user does not provide a timeout
WHEN
firebase emulators:start
is calledTHEN firestore emulator will fail to run with
Error: TIMEOUT: Port 8081 on localhost was not active within 60000ms
GIVEN a user provides a timeout in
firebase.json
for firestore of 10msWHEN
firebase emulators:start --only firestore
is calledTHEN firestore emulator will fail to run with
Error: TIMEOUT: Port 8081 on localhost was not active within 10ms
GIVEN a user provides a timeout in
firebase.json
for hosting of 10msWHEN
firebase emulators:start --only firestore
is calledTHEN firestore emulator will fail to run with
Error: TIMEOUT: Port 8081 on localhost was not active within 60000ms
**I understand these is a bit flacky - couldn't think any better at midnight 😛
I actually tested them with the old value of 30 secs
Sample Commands
In
firebase.json
: