Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FIREBASE_FRAMEWORKS_VERSION injectable for testing #6571

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Make FIREBASE_FRAMEWORKS_VERSION injectable for testing #6571

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bd6170
Make FIREBASE_FRAMEWORKS_VERSION injectable for testing
yifanyang Dec 5, 2023
b99ea94
address feedback
yifanyang Dec 5, 2023
1e51c3d
Merge branch 'master' into yifany/frameworks-version-injection
jamesdaniels Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/frameworks/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { SupportLevel } from "./interfaces";
import * as clc from "colorette";
import * as experiments from "../experiments";

export const NPM_COMMAND_TIMEOUT_MILLIES = 10_000;

Expand All @@ -25,7 +26,10 @@
"https://github.com/firebase/firebase-tools/issues/new?template=feature_request.md";
export const MAILING_LIST_URL = "https://goo.gle/41enW5X";

export const FIREBASE_FRAMEWORKS_VERSION = "^0.10.4";
const DEFAULT_FIREBASE_FRAMEWORKS_VERSION = "^0.10.4";
export const FIREBASE_FRAMEWORKS_VERSION =
(experiments.isEnabled("internaltesting") && process.env.FIREBASE_FRAMEWORKS_VERSION) ||
DEFAULT_FIREBASE_FRAMEWORKS_VERSION;
export const FIREBASE_FUNCTIONS_VERSION = "^4.3.0";
export const FIREBASE_ADMIN_VERSION = "^11.0.1";
export const SHARP_VERSION = "^0.32.1";
Expand All @@ -45,10 +49,10 @@

export const I18N_ROOT = "/";

export function GET_DEFAULT_BUILD_TARGETS() {

Check warning on line 52 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (18) 

Missing return type on function

Check warning on line 52 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (18) 

Missing JSDoc comment
return Promise.resolve(["production", "development"]);
}

export function DEFAULT_SHOULD_USE_DEV_MODE_HANDLE(target: string) {

Check warning on line 56 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (18) 

Missing return type on function

Check warning on line 56 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (18) 

Missing JSDoc comment
return Promise.resolve(target === "development");
}
Loading