Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop down to macos-12 environment to fix iOS CI #11451

Merged
merged 9 commits into from
Aug 14, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 11, 2023

Description

Apple CI is flaky, this PR is debug attempt. I think it is because of this issue: actions/runner-images#8023.

Dropping down to macos-12 appears to resolve the issue.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley marked this pull request as ready for review August 14, 2023 09:17
.github/workflows/e2e_tests.yaml Show resolved Hide resolved
@russellwheatley russellwheatley changed the title ci: debug ios ci ci: drop down to macos-12 environment to fix iOS CI Aug 14, 2023
@russellwheatley russellwheatley dismissed Lyokone’s stale review August 14, 2023 10:38

approved by others

@russellwheatley russellwheatley merged commit bd89304 into master Aug 14, 2023
@russellwheatley russellwheatley deleted the fix-apple-ci branch August 14, 2023 10:38
khanliKU pushed a commit to khanliKU/flutterfire that referenced this pull request Aug 18, 2023
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants