Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firebase_auth_web] WIP mapping package:firebase FirebaseError to PlatformException #1698

Closed
wants to merge 14 commits into from
Closed

[firebase_auth_web] WIP mapping package:firebase FirebaseError to PlatformException #1698

wants to merge 14 commits into from

Conversation

GregorySech
Copy link
Contributor

Description

I'm mapping the known firebasejs errors (received in package:firebase) to Platform exception as described in #1559.

It's still a work in progress, I'll try to add some tests and update documentation when I've got some free time.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@GregorySech
fix: creationTime and lastSignInTime are RFC1123, DateTime cannot par…
bcc8c90 
…se it.
@GregorySech
Merge pull request #1 from FirebaseExtended/master
a9f2573 
Add documentation for how to initialize the default app (#1545)
@GregorySech
Merge branch 'master' of github.com:GregorySech/flutterfire
2e96dc6
@GregorySech
chore: CHANGELOG entry and pubspec version bump.
6374da8
@GregorySech
fix: use http_parser.parseHttpDate instead of dart:io's HttpDate.parse
9bcaa99
@GregorySech
map firebasejs errors to unified errors.
8f23976
@GregorySech
Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire
5f66bd7 
 into FirebaseExtended-master

# Conflicts:
#	packages/firebase_auth/firebase_auth_web/CHANGELOG.md
#	packages/firebase_auth/firebase_auth_web/pubspec.yaml
@GregorySech
fix: firebase_auth_web version
7898023
@GregorySech
Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire
3724dbd 


# Conflicts:
#	packages/firebase_auth/firebase_auth_web/CHANGELOG.md
@GregorySech
fix: changed mapping to PlatformException instead of AuthException
7d3f80d
@yumin-chen
Copy link

yumin-chen commented Jan 15, 2020 •
edited
Loading

Thanks for the PR. Could you resolve the merge conflicts please?

@GregorySech
Copy link
Contributor Author

Thanks for the PR. Could you resolve the merge conflicts please?

This saturday afternoon I'll solve the conflicts.

@CDDelta CDDelta mentioned this pull request Jan 24, 2020
Merged
13 tasks
@illia-romanenko
Copy link

illia-romanenko commented Apr 1, 2020 •
edited
Loading

Hi @GregorySech, thanks for your PR! Will you be able to take a look at this and solve the conflicts?

@GregorySech
Copy link
Contributor Author

GregorySech commented Apr 2, 2020 •
edited
Loading

Hi @GregorySech, thanks for your PR! Will you be able to take a look at this and solve the conflicts?

Done, sorry for the delay. It seems I have to fix formatting, 1 sec

@flowhorn
Copy link

This PR is really helpful, as before we could'nt receive any error outputs. What is missing to be merged?

@GregorySech
Copy link
Contributor Author

I'm waiting review after solving the merge conflicts.

@nilsreichardt
Copy link
Contributor

Any updates?

@GregorySech
Copy link
Contributor Author

GregorySech commented Jun 24, 2020 •
edited
Loading

I will not work with Flutter for a while, I've re-resolved the conflicts. Can this be reviewed, please?

@nilsreichardt
Copy link
Contributor

Thanks for your work! Maybe you can remove WIP from the title, if this PR is ready for review 👍

@GregorySech
Copy link
Contributor Author

The related issue was closed and I no longer work with Flutter. Sorry for the time wasted.
If someone needs me to do something to pass this PR to someone else let me know but I'm closing it.

@firebase firebase locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucasreiners lucasreiners lucasreiners approved these changes

@wer-mathurin wer-mathurin wer-mathurin approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[firebase_auth_web] handle exception as documented in platform interface.
8 participants
@GregorySech @yumin-chen @illia-romanenko @flowhorn @nilsreichardt @lucasreiners @wer-mathurin @googlebot