Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firebase_auth] Migrate to Android v2 embedder. #2275

Merged
merged 17 commits into from
Apr 13, 2020
Merged

[firebase_auth] Migrate to Android v2 embedder. #2275

merged 17 commits into from
Apr 13, 2020

Conversation

zhenqiu1101
Copy link
Contributor

Description

Migrate firebase_auth plugin to android v2 embedder. Keep it backward compatible with v1.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@zhenqiu1101
Copy link
Contributor Author

@mehmetf @cyanglaz

cyanglaz
cyanglaz reviewed Apr 2, 2020
View reviewed changes
Copy link

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo tests

packages/firebase_auth/firebase_auth/test/firebase_auth_e2e.dart Outdated Show resolved Hide resolved
packages/firebase_auth/firebase_auth/test_driver/firebase_auth_e2e_test.dart Outdated Show resolved Hide resolved
@cyanglaz
Copy link

cyanglaz commented Apr 7, 2020

@collinjackson There seems to be flutter driver tests set up in this plugin to test the functionalities. Do we still need to convert them to e2e?
Also, how do those integration tests run in CI?

cyanglaz
cyanglaz approved these changes Apr 13, 2020
View reviewed changes
Copy link

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 3158071 into firebase:master Apr 13, 2020
@firebase firebase locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehmetf mehmetf mehmetf left review comments

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhenqiu1101 @cyanglaz @mehmetf @googlebot