fix(js): Marking root spans that have failed (#1615)

js/plugins/google-cloud/src/gcpOpenTelemetry.ts

@@ -307,6 +307,26 @@ class AdjustingTraceExporter implements SpanExporter {
       )
     );
 
+    // Check if we have a failure in the root span that requires special handling
+    const rootSpan = spans.find((s) =>
+      Object.keys(s.attributes).includes('genkit:isRoot')
+    );
+    if (rootSpan) {
+      const rootSpanFailed =
+        (rootSpan.attributes['genkit:state'] as string) === 'error';
+      const anotherFailedSpan = spans.find(
+        (s) =>
+          !Object.keys(s.attributes).includes('genkit:isRoot') &&
+          s.attributes['genkit:state'] === 'error'
+      );
+      if (rootSpanFailed && !anotherFailedSpan) {
+        rootSpan.attributes['genkit:failedSpan'] =
+          rootSpan.attributes['genkit:name'];
+        rootSpan.attributes['genkit:failedPath'] =
+          rootSpan.attributes['genkit:path'];
+      }
+    }
+
     return spans.map((span) => {
       this.tickTelemetry(span, allLeafPaths);
 
@@ -389,8 +409,6 @@ class AdjustingTraceExporter implements SpanExporter {
         };
   }
 
-  // This is a workaround for GCP Trace to mark a span with a red
-  // exclamation mark indicating that it is an error.
   private normalizeLabels(span: ReadableSpan): ReadableSpan {
     const normalized = {} as Record<string, any>;
     for (const [key, value] of Object.entries(span.attributes)) {

js/plugins/google-cloud/tests/traces_test.ts

@@ -171,6 +171,27 @@ describe('GoogleCloudTracing', () => {
     assert.equal(spans[1].attributes['genkit/rootState'], 'success');
   });
 
+  it('marks the root feature failed when it is the failure', async () => {
+    const testFlow = createFlow(ai, 'failingFlow', async () => {
+      await ai.run('good step', async () => {});
+      throw new Error('oops!');
+    });
+    try {
+      await testFlow();
+    } catch (e) {}
+
+    const spans = await getExportedSpans();
+    assert.equal(spans.length, 2);
+    assert.equal(spans[1].name, 'failingFlow');
+    assert.equal(spans[1].attributes['genkit/failedSpan'], 'failingFlow');
+    assert.equal(
+      spans[1].attributes['genkit/failedPath'],
+      '/{failingFlow,t:flow}'
+    );
+    assert.equal(spans[1].attributes['genkit/isRoot'], true);
+    assert.equal(spans[1].attributes['genkit/rootState'], 'error');
+  });
+
   it('adds the genkit/model label for model actions', async () => {
     const echoModel = ai.defineModel(
       {