Use random nonce, align CreateVaultAssetResponse with api

fireblocks · Mar 29, 2021 · e6cb804 · e6cb804
1 parent 3d45439
commit e6cb804
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/api-token-provider.ts b/src/api-token-provider.ts
@@ -9,7 +9,7 @@ export class ApiTokenProvider implements IAuthProvider {
     signJwt(path: string, bodyJson?: any): string {
         const token =  jwt.sign({
             uri: path,
-            nonce: Date.now(),
+            nonce: Math.floor(Math.random() * Number.MAX_SAFE_INTEGER),
             iat: Math.floor(Date.now() / 1000),
             exp: Math.floor(Date.now() / 1000) + 55,
             sub: this.apiKey,

diff --git a/src/fireblocks-sdk.ts b/src/fireblocks-sdk.ts
@@ -31,7 +31,8 @@ import {
     VaultAccountsFilter,
     RequestOptions,
     VaultBalancesFilter,
-    ValidateAddressResponse
+    ValidateAddressResponse,
+    CreateVaultAssetResponse
 } from "./types";
 
 export * from "./types";
@@ -388,7 +389,7 @@ export class FireblocksSDK {
      * @param vaultAccountId The vault account ID
      * @param assetId The asset to add
      */
-    public async createVaultAsset(vaultAccountId: string, assetId: string): Promise<AssetResponse> {
+    public async createVaultAsset(vaultAccountId: string, assetId: string): Promise<CreateVaultAssetResponse> {
         return await this.apiClient.issuePostRequest(`/v1/vault/accounts/${vaultAccountId}/${assetId}`, {});
     }
 

diff --git a/src/types.ts b/src/types.ts
@@ -31,7 +31,10 @@ export interface UnfreezeTransactionResponse {
 
 export interface CreateVaultAssetResponse {
     id: string;
-    eosAccountName?: string;
+    address: string;
+    legacyAddress: string;
+    tag: string;
+    eosAccountName: string;
 }
 
 export interface WalletAssetResponse extends AssetResponse {