Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FIR-42592): allow agg index without key columns #150

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Jan 14, 2025

Description

Aggregation index SQL no longer requires key columns to be present as a part of it. Reflecting this change in dbt compiler.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant