Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding security scan #36

Merged
merged 8 commits into from
Feb 3, 2022
Merged

ci: Adding security scan #36

merged 8 commits into from
Feb 3, 2022

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Jan 14, 2022

Resolves # FIR-10119

Description

Adding security scan action to automatically spot any security hotspots via Sonar Cloud and Fossa.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have updated CHANGELOG.md and added information about my change.
  • If this PR requires a new PyPI release I have bumped the version number.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • I have verified that this PR contains only code changes relevant to this PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -12,6 +12,10 @@

- Disallowed setting of `threads` in `profiles.yml` to a value greater than 1.

Copy link
Contributor

@ericf-firebolt ericf-firebolt Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to merge correctly. 0.21.8 has already been released, so it should be 0.21.9. However, 0.21.8 has been yanked temporarily due to an installation issue. I think this PR needs to be on hold until a fixed version of 0.21.8 is released.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this confirms no security issues are present at the moment so we can hold off merging until everything's fixed in main.

@ericf-firebolt ericf-firebolt merged commit 9f83973 into main Feb 3, 2022
@ericf-firebolt ericf-firebolt deleted the add-sequrity-scan branch February 3, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants