feat: Bump version number and update adapter to work with dbt v1.0.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction. Minor change to field values in profiles.yml to match internal nomenclature: host -> api_endpoint.
… working. I think that's actually an issue in main.
…ses of jaydebeapi, Java, and the JDBC.
…to move_to_our_db_api
…bt-firebolt into move_to_our_db_api
tests/integration/firebolt.dbtspec
Outdated
| @@ -6,8 +6,10 @@ target: | |||
| engine_name: "{{ env_var('ENGINE_NAME') }}" | |||
| user: "{{ env_var('USER_NAME') }}" | |||
| password: "{{ env_var('PASSWORD') }}" | |||
| schema: "{{ env_var('SCHEMA') }}" | |||
There was a problem hiding this comment.
Should we just hardcode this value?
There was a problem hiding this comment.
No, this is either a by-team or by-user setting, so it needs to be set locally. Since we don't have schemas, this string just gets appended to each table name, so people aren't overwriting each others' tables. As an example, my "schema" is "emf," so all my table names are prefixed with "emf_"
There was a problem hiding this comment.
Ach, sorry. Yes, it should be hard-coded. I was thinking of profiles.yml, not this integration test file.
dbt/adapters/firebolt/connections.py
Outdated
| @@ -100,9 +100,9 @@ def open(cls, connection): | |||
| engine_name = credentials.engine_name | |||
| error_msg_append = '' | |||
| raise EngineOfflineException( | |||
There was a problem hiding this comment.
There is no need for this exception since SDK checks running engine by itself and raises an appropriate error
stepansergeevitch
approved these changes
Feb 10, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FIR-10759
Unblocks FIR-10765
Checklist
CHANGELOG.mdand added information about my change.Note: This PR is a branch of #10 , so is currently blocked until that is merged.