feat(FIR-38127): Add struct support #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
changed the title
|
| s: { a: [1, 2], b: "hello" } | ||
| }; | ||
| // Missing closing parenthesis | ||
| const meta = [{ name: "s", type: "struct(a array(int), b text" }]; |
There was a problem hiding this comment.
I believe we should fail here. This is something that's not expected to be received from the backend and we should fail to avoid unexpected results for customers
There was a problem hiding this comment.
As discussed offline this leads to uncertainty, is this a new type and we default to string or is this a malformed existing type. I suppose we can check the prefix - if it's correct but we're not able to parse the rest then we're malformed. But it's a little arbitrary IMO.
stepansergeevitch
approved these changes
Dec 19, 2024
ptiurin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the logic for struct, including allowing columns with spaces.
Added tests for struct and geography since we support it.