Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start dirty page tracking implementation in vm-memory. #2149

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Start dirty page tracking implementation in vm-memory. #2149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db9e5d
Create the vm-memory proxy crate.
sandreim Sep 23, 2020
7aa10bc
Implement dirty Bitmap object.
sandreim Sep 28, 2020
2002ffd
Switch to local vm-memory proxy.
sandreim Sep 28, 2020
d086a32
Update AMD coverage.
sandreim Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions src/vm-memory/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[package]
name = "vm-memory"
version = "0.1.0"
authors = ["Amazon Firecracker team <[email protected]>"]
edition = "2018"

[dependencies]
vm-memory-upstream = { package = "vm-memory", version = ">=0.2.2", features = ["backend-mmap"] }

[dev-dependencies]
vmm-sys-util = ">= 0.4.0"
16 changes: 16 additions & 0 deletions src/vm-memory/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
//
// Portions Copyright 2017 The Chromium OS Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the THIRD-PARTY file.
Comment on lines +4 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this still the case?


//! This is a "proxy" crate for Firecracker. It links to upstream vm-memory implementation
//! and re-exports symbols for consumption.
//! This crate implements a custom vm-memory backend implementation that overrides the
//! upstream implementation and adds dirty page tracking functionality.
mod mmap;

pub use mmap::{GuestMemoryMmap, GuestRegionMmap};
// TODO: re-export things from upstream so we don't need to import both this crate and the real
// vm-memory locally and consume the wrong `GuestMemoryMmap`.
Loading