fix libfdt linking when compiled using -fstack-protector #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
Status: Awaiting review
acatangiu
reviewed
May 28, 2021
Comment on lines
+1
to
+6
| [package] | ||
| name = "libfdt-bindings" | ||
| version = "0.1.0" | ||
| authors = ["Amazon Firecracker team <[email protected]>"] | ||
| edition = "2018" | ||
| build = "build.rs" |
There was a problem hiding this comment.
I'd prefer we only build this under aarch64. Either with an arch gate at the crate level (the crate wouldn't even exist on other archs), or with a code-level gate (crate exists but is empty).
There was a problem hiding this comment.
I couldn't find a way to add an arch gate at the crate level, but there are code-level gates. Also I added a gate for the dependencies.
luminitavoicu
previously approved these changes
Jun 3, 2021
added 3 commits
June 3, 2021 14:03
Signed-off-by: Serban Iorga <[email protected]>
Signed-off-by: Serban Iorga <[email protected]>
Signed-off-by: Serban Iorga <[email protected]>
acatangiu
previously approved these changes
Jun 3, 2021
Signed-off-by: Serban Iorga <[email protected]>
luminitavoicu
approved these changes
Jun 3, 2021
acatangiu
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
fix libfdt linking when compiled using
-fstack-protectorDescription of Changes
As part of #2579 we pushed a commit that involved compiling libfdt using
-fno-stack-protectorin order to workaround rust-lang/rust#79791 .This is a cleaner fix that enables us to compile firecracker using rust toolchain 1.52.1 even when libfdt is compiled using
-fstack-protectorrust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.