util: fine grained deep asan support in spad #4196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
5 times, most recently
from
19f641a to
8b2c34f
Compare
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
from
6f56694 to
6f31bda
Compare
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
from
6f31bda to
3b19759
Compare
yufeng-jump
reviewed
Feb 12, 2025
| } | ||
|
|
||
| FD_FN_UNUSED static void | ||
| test_spad_deepasan( fd_spad_t * spad ) { |
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
from
3b19759 to
90f6f6d
Compare
asiegel-jt
reviewed
Feb 13, 2025
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
from
acd7e2e to
b75297b
Compare
cali-jumptrading
force-pushed
the
cali/spad-deep-asan-clean
branch
from
b75297b to
25444bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fine-grained deep asan support in spad by making all allocations in spad have a minimum alignment of 8 bytes when DEEPASAN is enabled / a minimum alignment of 4 bytes when MSAN is enabled.
Also note that manual asan poisoning must be on 8-byte aligned addresses, but can be done on arbitrary sizes.
Currently, an MSAN build does not compile... will have to punt this to a later issue.