Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description based rules breaking with (space) usage. #7609

Closed
4 tasks done
th3guard1an opened this issue Jun 6, 2023 · 8 comments
Closed
4 tasks done

Description based rules breaking with (space) usage. #7609

th3guard1an opened this issue Jun 6, 2023 · 8 comments
Labels
fixed Bugs that are fixed (in a coming release).

Comments

@th3guard1an
Copy link

th3guard1an commented Jun 6, 2023

Support guidelines

I've found a bug and checked that ...

Description

I have a set of rules in which I specify the contents on the description, (either with "description is" description contains"), and some simply do not work at all.
Eg, "The bank transfer".
Expected behaviour: Descrition is "The bank transferr" = detection
Actual behaviour: Doesn't recognize any transaction with this description.

Workarround:

Description contains: "The"
Description contains: "bank"
Description contains: "transfer"

I can't be sure when this problem arrised.

Debug information

Debug information generated at 2023-06-06 00:00:00 Europe/Lisbon for Firefly III version 6.0.10.

Scope Version
Firefly III 6.0.10
Firefly III API 2.0.1
DB version 19 (exp. 19)
Docker No
PHP 8.2.6
Host Linux
System info Value
System TZ Europe/Lisbon
Browser TZ Europe/Lisbon
App environment local
App debug mode false
App cache driver file
App logging notice, stack
Display errors Off
Error reporting ALL errors
Max upload 2097152 (2 MB)
Interface fpm-fcgi
Default language pt_PT
Default locale pt_PT
BCscale 12
DB drivers mysql
Current driver mysql
Trusted proxies (.env) 192.168.1.83
User info Value
Login provider eloquent
User guard web
Headers N/A, N/A
Stateful domains
Session start 2023-05-06 00:00:00
Session end 2023-06-05 23:59:59
Session first 2019-01-01 00:00:00
User ID 1
User language en_US
User locale pt_PT
Attempt at "pt_PT.utf8" 'pt_PT.utf8'
Attempt at "pt_PT.UTF-8" 'pt_PT.UTF-8'
User agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Expected behaviour

No response

Steps to reproduce

No response

Additional info

No response

@JC5
Copy link
Member

JC5 commented Jun 6, 2023

I can't replicate this. On the demo site, using "daily shot" as the trigger value works fine.

@BoGnY
Copy link
Contributor

BoGnY commented Jun 14, 2023

I've the same problem...
Trigger with "description contains" shown related transaction correctly, but when applied, no transaction changes....

Related transaction:
image

Rules applied:
image

@JC5
Copy link
Member

JC5 commented Jun 14, 2023

If your bank adds many spaces, that could be the problem. They are generally not visible in HTML but they may show up when you edit the transaction.

@BoGnY
Copy link
Contributor

BoGnY commented Jun 14, 2023

You means many spaces on description?
I've checked using phpmyadmin but there aren't many spaces, only one...

But, even trying "description contains" and "description starts" with only "Commissioni" related transactions are shown but rules don't change nothing..

Oh maybe I found the problem... I make some test 👍🏻

@BoGnY
Copy link
Contributor

BoGnY commented Jun 14, 2023

Mmmmmm seems problem is on date range or account id..

SearchRuleEngine::find() founds transaction:
related transaction check.log

SearchRuleEngine::fire() don't found transaction:
rule applied.log

The differences are operator (applied only on fire()):

[2023-06-14 12:15:56] local.DEBUG: SearchRuleEngine:: add local added operator: date_after:"2022-12-28"  
[2023-06-14 12:15:56] local.DEBUG: SearchRuleEngine:: add local added operator: date_before:"2023-06-14"  
[2023-06-14 12:15:56] local.DEBUG: SearchRuleEngine:: add local added operator: account_id:"1,1,1,1"  

@JC5
Copy link
Member

JC5 commented Jun 14, 2023

I see what you mean, it's a problem in the test / execute form. I'll pick it up!

@JC5 JC5 added bug fixed Bugs that are fixed (in a coming release). labels Jun 14, 2023
@JC5 JC5 added this to Firefly III Jun 14, 2023
@JC5 JC5 moved this to Done in Firefly III Jun 14, 2023
@JC5 JC5 added this to the firefly-iii-v6.0.14 milestone Jun 14, 2023
JC5 added a commit that referenced this issue Jun 14, 2023
@BoGnY
Copy link
Contributor

BoGnY commented Jun 14, 2023

I've tested and I confirm is fixed 👍🏻

@JC5 JC5 closed this as completed in 6893485 Jun 21, 2023
@github-actions
Copy link
Contributor

Hi there! This is an automatic reply. Share and enjoy

This issue is now 🔒 closed. Please be aware that closed issues are not watched.

  • If the original bug is not actually fixed, please feel free to open a new issue. Please refer to this issue for clarity.
  • Follow-up questions must be posted in a new discussion
  • Further replies to this issue will get no response.

Thank you for your contributions.

@JC5 JC5 removed this from Firefly III Jun 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

3 participants