Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#296 | @willwillman | debug currentPackagePath #329

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WillWillman
Copy link

@WillWillman WillWillman commented Aug 29, 2023

Appears that the currentPackagePath and jestBinPath does not account for the possibility of certain mono-repos where sub packages share a node_modules directory in the root.

this PR allows the user to use a jestPathFromWorkspace setting to adjust where the runner looks for jest executable

@WillWillman WillWillman marked this pull request as draft August 29, 2023 23:13
@domsleee
Copy link
Collaborator

domsleee commented Sep 7, 2023

Salutations

What's an example structure this is trying to fix?

You were discussing changeDirectoryToWorkspaceRoot as true in #296, maybe it's an idea to change how the debug behaves when this is set to true, rather than introducing a new configuration? Hard to say without a reproduction 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants