Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: use into_values in mod.rs #471

Merged
merged 1 commit into from
Oct 11, 2022
Merged

clippy: use into_values in mod.rs #471

merged 1 commit into from
Oct 11, 2022

Conversation

darnuria
Copy link
Contributor

rationale:

warning: iterating on a map's values
  --> src/json/map/mod.rs:94:24
   |
94 |           let tilesets = other
   |  ________________________^
95 | |             .tilesets
96 | |             .into_iter()
97 | |             .map(|(_, tileset)| tileset)
   | |________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
   = note: `#[warn(clippy::iter_kv_map)]` on by default
help: try
   |
94 ~         let tilesets = other
95 +             .tilesets.into_values()
   |

rationale:

```
warning: iterating on a map's values
  --> src/json/map/mod.rs:94:24
   |
94 |           let tilesets = other
   |  ________________________^
95 | |             .tilesets
96 | |             .into_iter()
97 | |             .map(|(_, tileset)| tileset)
   | |________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
   = note: `#[warn(clippy::iter_kv_map)]` on by default
help: try
   |
94 ~         let tilesets = other
95 +             .tilesets.into_values()
   |
```
@orhun orhun changed the title [clippy] use into_values in mod.rs. clippy: use into_values in mod.rs Oct 11, 2022
@orhun orhun merged commit 29127fa into fishfolk:main Oct 11, 2022
@darnuria darnuria deleted the clippy/into_values branch October 11, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants