FCE-562 Restore participant metadata #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stasiak
force-pushed
the
FCE-562-restore-participant-metadata
branch
from
56af00e to
c689981
Compare
kamil-stasiak
force-pushed
the
FCE-562-restore-participant-metadata
branch
from
7e6d01b to
a25b4f5
Compare
…CE-562-restore-participant-metadata
czerwiukk
reviewed
Sep 27, 2024
Co-authored-by: Adrian Czerwiec <[email protected]>
czerwiukk
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
metadatafield now holdspeerandservermetadata.SDK doesn't handle server metadata at all. There is a separate task for that:
https://linear.app/swmansion/issue/FCE-563/handle-server-metadata-in-web-client-sdk
This is a basic fix. I didn't want to refactor or redesign anything.
Motivation and Context
Peer / Participant metadata didn't work.
Types of changes
Bug fix (non-breaking change which fixes an issue)