[FCE-571] Update readme and typedoc #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironiasty
requested review from
kamil-stasiak,
czerwiukk and
karkakol
and removed request for
kamil-stasiak and
czerwiukk
mironiasty
commented
Sep 24, 2024
| @@ -41,5 +53,3 @@ export type { | |||
| AuthErrorReason, | |||
| Encoding, | |||
| } from "@fishjam-cloud/ts-client"; | |||
|
|
|||
| export { FishjamClient } from "@fishjam-cloud/ts-client"; | |||
There was a problem hiding this comment.
@kamil-stasiak @czerwiukk Is there reason to keep this class exported? We have useFishjamClient hook.
mironiasty
changed the title
czerwiukk
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify main readme's and add links to current documentation
Update how
typedocis generated to make it a little more useful.Also fix FCE-592 by adding new footer to readme
Motivation and Context
Let's have better readme's :)
Types of changes
not work as expected)