Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCE-738] Add @bufbuild/protobuf to ts-client dependency #149

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mironiasty
Copy link
Member

@mironiasty mironiasty commented Oct 18, 2024

Description

This PR updates dependencies for project.

  • It looks like react and ts-proto are not required in project 🤔
  • we should use @bufbuild/protobuf as dependency

Motivation and Context

Let's have correct dependencies for project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Copy link

linear bot commented Oct 18, 2024

@mironiasty mironiasty marked this pull request as ready for review October 18, 2024 10:11
@mironiasty mironiasty merged commit 66f9ed5 into main Oct 18, 2024
2 checks passed
@mironiasty mironiasty deleted the fix-proto-deps branch October 18, 2024 11:34
@mironiasty mironiasty mentioned this pull request Oct 18, 2024
3 tasks
mironiasty added a commit that referenced this pull request Oct 21, 2024
## Description

This is hotfix release to fix dependency issue (see #149 )

## Motivation and Context

Bug that prevent from using latest release without some hacks on
developer side

## Types of changes

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to
      not work as expected)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants