Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor screenshare to allow audio #44

Merged
merged 15 commits into from
Aug 12, 2024
Merged

Conversation

czerwiukk
Copy link
Collaborator

Description

Implements use screenshare hook.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@czerwiukk czerwiukk requested a review from kamil-stasiak July 23, 2024 13:32
@czerwiukk czerwiukk self-assigned this Jul 23, 2024
Copy link

linear bot commented Jul 23, 2024

@czerwiukk czerwiukk force-pushed the FCE-290/screenshare-manager branch from 0ee12af to cd0e16e Compare July 23, 2024 13:34
@czerwiukk czerwiukk marked this pull request as draft July 23, 2024 13:38
packages/react-client/src/screenShareTrackManager.ts Outdated Show resolved Hide resolved
packages/react-client/src/utils/tracks.ts Outdated Show resolved Hide resolved
packages/react-client/src/utils/tracks.ts Outdated Show resolved Hide resolved
packages/react-client/src/utils/tracks.ts Outdated Show resolved Hide resolved
@czerwiukk czerwiukk force-pushed the FCE-290/screenshare-manager branch from 3b73cb9 to 9d9cdfb Compare July 24, 2024 10:20
@czerwiukk czerwiukk force-pushed the FCE-290/screenshare-manager branch 3 times, most recently from bdc5e71 to 08353c5 Compare August 12, 2024 11:29
@czerwiukk czerwiukk force-pushed the FCE-290/screenshare-manager branch from 4f32d7f to 7c20629 Compare August 12, 2024 12:45
@czerwiukk czerwiukk marked this pull request as ready for review August 12, 2024 12:54
@czerwiukk czerwiukk merged commit 8571826 into main Aug 12, 2024
2 checks passed
@czerwiukk czerwiukk deleted the FCE-290/screenshare-manager branch August 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants