Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Small refactor #53

Merged
merged 3 commits into from
Aug 12, 2024
Merged

[NO-TICKET] Small refactor #53

merged 3 commits into from
Aug 12, 2024

Conversation

mironiasty
Copy link
Member

@mironiasty mironiasty commented Aug 9, 2024

Description

Create array with all events, to make sure that same events are binded and un-binded. Also change few keywords.

Motivation and Context

I started to update create function. But turns out, to make changes I wanted - I would have to remove TrackMetadata generic type. And this would require muuch bigger effort.
So I could either remove this changes or make small PR with them.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@mironiasty mironiasty changed the title Small refactor [NO-TICKET} Small refactor Aug 12, 2024
@mironiasty mironiasty changed the title [NO-TICKET} Small refactor [NO-TICKET] Small refactor Aug 12, 2024
@mironiasty mironiasty marked this pull request as ready for review August 12, 2024 10:54
@kamil-stasiak kamil-stasiak merged commit bc48603 into main Aug 12, 2024
2 checks passed
@kamil-stasiak kamil-stasiak deleted the create-refactor branch August 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants