[FCE-400] Support names in demo app (and add missing CI checks) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironiasty
changed the title
mironiasty
commented
Aug 22, 2024
Comment on lines
+19
to
+20
| defaultRoomName: localStorage.getItem("roomName") ?? "", | ||
| defaultUserName: localStorage.getItem("userName") ?? "", |
| @@ -67,7 +67,9 @@ function App() { | |||
| )} | |||
|
|
|||
| <div className="absolute bottom-2 left-0 w-full grid place-content-center text-center text-xs z-30"> | |||
| <p className="bg-slate-100/60 px-1 rounded-sm">{id}</p> | |||
| <p className="bg-slate-100/60 px-1 rounded-sm"> | |||
| {(metadata as { name?: string })?.name ?? id} | |||
There was a problem hiding this comment.
that inline type is not the prettiest, but will do the job until we have the predefined metadata typed by the sdk
There was a problem hiding this comment.
That is my assumption - soon we should have these values typed better, so then it will be fixed.
Comment on lines
+10
to
13
| "lint:check": "eslint . --ext .ts,.tsx", | ||
| "format": "prettier --write . --ignore-path ./.eslintignore", | ||
| "format:check": "prettier --check . --ignore-path ./.eslintignore", | ||
| "preview": "vite preview" |
mironiasty
requested review from
czerwiukk and
kamil-stasiak
and removed request for
czerwiukk
czerwiukk
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow test app to handle user names in similar way as mobile app
Also add missing lint/format CI checks. And reformat code using our rules
Motivation and Context
Easier app testing
Types of changes
not work as expected)