Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fce 394/track middleware #68

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Fce 394/track middleware #68

merged 10 commits into from
Aug 26, 2024

Conversation

czerwiukk
Copy link
Collaborator

Description

Adds track middleware to screenshare and video/audio managers.
Additionally, the track manager has been rewritten from a class to react hook.

Motivation and Context

Track middleware allows easy manipulation of the tracks managed by the SDK before streaming them out.

I also rewritten the track manager to a hook, because I needed a state to store the middleware.
Adding a property to the TrackManager class wasn't enough, I also needed to synchronize with the react state.
Instead of pursuing the event emitting pattern, I decided to introduce an internal hook.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Copy link

linear bot commented Aug 23, 2024

@czerwiukk czerwiukk marked this pull request as draft August 23, 2024 13:31
@czerwiukk czerwiukk self-assigned this Aug 23, 2024
@czerwiukk czerwiukk marked this pull request as ready for review August 23, 2024 18:53
@czerwiukk czerwiukk force-pushed the FCE-394/track-middleware branch from 8467c58 to bc21faa Compare August 23, 2024 18:53
@czerwiukk czerwiukk force-pushed the FCE-394/track-middleware branch from 5d80d25 to a35ad5f Compare August 26, 2024 12:09
@czerwiukk czerwiukk merged commit dc7be34 into main Aug 26, 2024
2 checks passed
@czerwiukk czerwiukk deleted the FCE-394/track-middleware branch August 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants