-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fce 394/track middleware #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czerwiukk
commented
Aug 23, 2024
8467c58
to
bc21faa
Compare
kamil-stasiak
approved these changes
Aug 26, 2024
kamil-stasiak
approved these changes
Aug 26, 2024
5d80d25
to
a35ad5f
Compare
kamil-stasiak
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds track middleware to screenshare and video/audio managers.
Additionally, the track manager has been rewritten from a class to react hook.
Motivation and Context
Track middleware allows easy manipulation of the tracks managed by the SDK before streaming them out.
I also rewritten the track manager to a hook, because I needed a state to store the middleware.
Adding a property to the TrackManager class wasn't enough, I also needed to synchronize with the react state.
Instead of pursuing the event emitting pattern, I decided to introduce an internal hook.
Types of changes
not work as expected)