Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool logic in portfolio_history config.enabled #7

Closed
wants to merge 1 commit into from

Conversation

jtcohen6
Copy link

resolves #6

Are you a current Fivetran customer?
Jeremy Cohen @ dbt Labs

What change(s) does this PR introduce?
Fixes a faulty config!

Did you update the CHANGELOG?

  • Yes — not yet

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz
Copy link
Collaborator

Thanks so much for being so quick and opening this PR @jtcohen6! We actually caught this earlier in the morning and opened PR #5 to address the issue. We should be releasing it shortly 😄

@jtcohen6
Copy link
Author

jtcohen6 commented Jan 27, 2023

@fivetran-joemarkiewicz My bad for not thinking to look at the one other open PR!

@jtcohen6 jtcohen6 closed this Jan 27, 2023
@jtcohen6 jtcohen6 deleted the patch-1 branch January 27, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Small typo in boolean logic for config: enabled
2 participants