Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Test fail on duplicate found #12

Closed
2 of 4 tasks
raphaelvarieras opened this issue May 18, 2023 · 4 comments · Fixed by fivetran/dbt_app_reporting#16
Closed
2 of 4 tasks

[Bug] Test fail on duplicate found #12

raphaelvarieras opened this issue May 18, 2023 · 4 comments · Fixed by fivetran/dbt_app_reporting#16
Assignees
Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:bug Something is broken or incorrect update_type:testing Primary focus requires testing updates

Comments

@raphaelvarieras
Copy link

raphaelvarieras commented May 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Test fail due to records not unique on date_day, app_platform, app_name, and country_short. My data is displaying duplicate records for country code TR:

image

Relevant error log or model output

Failure in test dbt_utils_unique_combination_of_columns_app_reporting__country_report_date_day__app_platform__app_name__country_short (models/app_reporting.yml)

Expected behavior

No errors

dbt Project configurations

N/A

Package versions

0.3.0

What database are you using dbt with?

snowflake

dbt Version

1.5

Additional Context

See this issue on Google Play for additional background.

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-joemarkiewicz
Copy link
Collaborator

Hi @raphaelvarieras thanks for opening this issue! I think this can actually be an easy fix since the country_code_long is unique. We may just need to adjust the test to incorporate the country_code_long as well.

Would you be concerned with the data if we adjusted that test?

@raphaelvarieras
Copy link
Author

No, no particularly concerned. I am much more concerned that Google and now Apple don't seem to vet any of the data they're publishing on their app stores!

@fivetran-joemarkiewicz
Copy link
Collaborator

I would agree with you there! Thanks @raphaelvarieras, I will plan to have someone from my team work on these test updates in the coming sprint. Thanks again!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:bug Something is broken or incorrect priority:p3 Affects many users; can wait status:in_progress Currently being worked on update_type:testing Primary focus requires testing updates labels May 19, 2023
@fivetran-joemarkiewicz
Copy link
Collaborator

@raphaelvarieras I actually had some free time this morning and was able to get around to working on the bugfix. If you have time, would you be able to test the WIP branch I have with the test modification applied. Let me know if this resolves the test error on your end!

packages:
  - git: https://github.com/fivetran/dbt_app_reporting.git
    revision: bugfix/country-long-test-addition
    warn-unpinned: false 

Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:bug Something is broken or incorrect update_type:testing Primary focus requires testing updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants