bugfix/country-long-test-addition

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature:

Issue #12 from the Apple Store package.

This PR will result in the following new package version: v0.3.1

This change is only adjusting a unique combination of columns test to capture the nuance of the source data. This will not be a breaking change for existing users.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR adds the country_long field in the unique combination of columns test for the app_reporting__country_report. It has been identified that Google and Apple will sometimes provide records with different country_long names; however, they will be the same country_short. This is due to some countries having a multiple country_long spelling variations. Please see the issue linked above for an example of this scenario and why the test is needed to account for the source data nuance.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• [n/a] dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

To test these changes I ran the tests on our existing data and noticed the original test passed. This was as expected since we do not have any double countries in our data. That being said, I was able to modify some seed data to create a double record and saw the test pass as expected following the new entry.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• [n/a] README updates have been applied (if applicable)
• [n/a] DECISIONLOG updates have been updated (if applicable)
• [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

👯

[fivetran-joemarkiewicz]

This branch may be tested by using the following config in your local package.yml

packages:
  - git: https://github.com/fivetran/dbt_app_reporting.git
    revision: bugfix/country-long-test-addition
    warn-unpinned: false 

[fivetran-catfritz]

I was able to recreate the test error, which was resolved with the new branch. I also tested Apple and Google individually, and I confirm their corresponding tests do not cause any issues. Lgtm!

[fivetran-catfritz]

Just a quick note here--I updated the changelog to only mention Apple data since the Google data comes in only as a short code. We add in the long name later, so the same issue does not occur.