Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/add alt country names #11

Merged
merged 9 commits into from
May 3, 2023
Merged

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented May 2, 2023

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_apple_store_source#8

This PR will result in the following new package version:

v0.3.0 because the source package has a breaking change (and users of the transform package will also need to re seed the country code data)

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
most of the changes happened in the source PR, but here:

  • i also added a Step in the readme about seeding the country code file, since we don't really document as a necessary step anywhere
  • we added newly added countries to the one of the seed files so that we can test this out appropriately (ie those countries join properly in the territory report and have non-null data).

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

validation for this is largely here in the transform package, where i

  1. pointed to the working branch of the source package
  2. added a couple of new countries to one of the territory seed files (specifically Kosovo and two different versions of spelling for the Ivory Coast)
  3. reseeded and reran everything upstream of the territory report
  4. confirmed that the new countries had non-null data from the country code file (so the joins worked)

image

5. confirmed that different spellings of a country will indeed split out into distinct rows (but can be aggregated by their identical country codes)

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

@fivetran-jamie fivetran-jamie self-assigned this May 2, 2023
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie this looks good to go! I only have a few minor requests to update some documentation similar to how you made updates in the original source package. Thanks for working through these!

CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit 6ab1e31 into main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants