Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add sync_id to stg_fivetran_log__log #78

Closed
2 of 4 tasks
camcyr-at-brzwy opened this issue Mar 22, 2023 · 5 comments
Closed
2 of 4 tasks

[Feature] Add sync_id to stg_fivetran_log__log #78

camcyr-at-brzwy opened this issue Mar 22, 2023 · 5 comments
Labels
type:enhancement New functionality or enhancement

Comments

@camcyr-at-brzwy
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Add the sync_id field to the stg_fivetran_log__log model. This would be useful for quickly identifying which sync events are associated with.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @camcyr-at-brzwy thanks so much for suggesting this feature request!

I think this would be a great addition to the package and I see the value of being able to leverage the sync_id in the log models. I noticed you are interested in contributing this feature! If you would like to open a PR to contribute this new field I would be happy to review your PR and work with you to integrate your contribution into the next release.

Let me know if this would be of interest to you. Otherwise, my team can work to fold this into an upcoming sprint.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Mar 23, 2023
@camcyr-at-brzwy
Copy link
Contributor Author

Hey @fivetran-joemarkiewicz! Wanted to let you know that I just opened this PR to make this change.

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks so much @camcyr-at-brzwy! I will review your PR in our current sprint and will let you know if I have any comments or suggestions directly in your PR 😄

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks again for opening this feature ad contributing to the package! This feature is now live in the latest release of the package.

@camcyr-at-brzwy
Copy link
Contributor Author

@fivetran-joemarkiewicz Awesome! Glad I could help out and super excited that this is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants