Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sync_id as well as docs #79

Merged

Conversation

camcyr-at-brzwy
Copy link
Contributor

@camcyr-at-brzwy camcyr-at-brzwy commented Mar 23, 2023

Are you a current Fivetran customer?

Yes, Cameron Cyr, Senior Data Engineer @ Breezeway

What change(s) does this PR introduce?

This adds the sync_id to the stg_fivetran_log__log model. This will make it easier to understand which sync the log events are associated with.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature 78
  • No

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)
    dbt build 18:57:25 Completed successfully 18:57:25 18:57:25 Done. PASS=54 WARN=0 ERROR=0 SKIP=0 TOTAL=54

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

👾

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camcyr-at-brzwy thanks again for working through this feature request PR! 🎉

I just reviewed your changes and they overall look great! The only piece I am concerned about is if there are any customers who may not have sync_id. I am currently checking with our product team to validate this fields existence in all connectors. If it is not, we have a few changes we can apply to account for this.

Additionally, we are currently evaluating addressing Issue #56 this sprint. Therefore, we will likely batch this update with that one if we decide to move forward with addressing that issue. If not, you will likely still see these changes integrated into the latest release by the end of our current sprint (next week). Thanks again!

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working through this update @camcyr-at-brzwy! With the slight modifications applied to this package, it looks good to go! You can likely expect this to go live tomorrow morning.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit de9b667 into fivetran:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants