Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grain of user audit activity model #102

Merged

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Dec 4, 2023

PR Overview

This PR will address the following Issue/Feature:
#100

This PR will result in the following new package version:

v0.1.3.1 -- updated in SQL server branch

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

NO SQL CHANGES

Bug Fixes

  • Adjusts the uniqueness test on the recently introduced fivetran_platform__audit_user_activity model.
    • Previously, the log_id was erroneously considered the primary key of this model.
    • Now, the model tests for unique combinations of log_id and occurred_at.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml -- in other branch
    • indexed within integration_tests/dbt_project.yml -- in other branch
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🐱

@fivetran-jamie fivetran-jamie self-assigned this Dec 4, 2023
@fivetran-jamie fivetran-jamie marked this pull request as ready for review December 5, 2023 19:10
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie LGTM with one small suggestion to the CHANGELOG.

Co-authored-by: Joe Markiewicz <[email protected]>
@fivetran-jamie fivetran-jamie merged commit b70b8a2 into releases/v1.3.latest Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants