Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating unique_table_sync_key to address incremental unique test fail #92

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

JustMaris
Copy link
Contributor

Proposing a change for an easy fix

Please provide your name and company
Maris Popens, Easypark

Link the issue/feature request which this PR is meant to address

#90

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

Implementing what the issue describes and what was discussed under the issue.

How did you validate the changes introduced within this PR?

Which warehouse did you use to develop these changes?

Did you update the CHANGELOG?

  • Yes
  • No

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes
  • No

Provide an emoji that best describes your current mood

😪

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Oct 17, 2023

Hi @JustMaris thank you for opening this PR! My team will review this today and let you know if I have any questions.

Would you be comfortable with me making updates directly to this branch? Most likely nothing major, just some under the hood updates to prepare the branch for release.

@JustMaris
Copy link
Contributor Author

Hi @JustMaris thank you for opening this PR! My team will review this today and let you know if I have any questions.

Would you be comfortable with me making updates directly to this branch? Most likely nothing major, just some under the hood updates to prepare the branch for release.

That's completely fine. I didn't know everything that needs to be done, and due to that didn't do everything that needs to be done.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustMaris thanks again for opening this PR to address the open issue of the unique key in the end model. I have just been able to review your changes and they look great! I made some additional under the hood updates to ensure this will be ready to merge and release.

This will result in the v1.2.0 release of the fivetran platform package. As we are changing the unique key of an incremental model we will need to make this a major update in order to ensure users capture the changes in a full refresh.

Thanks again and I will push this forward for to our internal release process. You should see this live within the week. 😄

@JustMaris
Copy link
Contributor Author

@JustMaris thanks again for opening this PR to address the open issue of the unique key in the end model. I have just been able to review your changes and they look great! I made some additional under the hood updates to ensure this will be ready to merge and release.

This will result in the v1.2.0 release of the fivetran platform package. As we are changing the unique key of an incremental model we will need to make this a major update in order to ensure users capture the changes in a full refresh.

Thanks again and I will push this forward for to our internal release process. You should see this live within the week. 😄

Glad to hear that. Looking forward to the release, to have one less uniqueness test to address. 😃

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 6864ac3 into fivetran:main Oct 17, 2023
@JustMaris JustMaris deleted the patch-1 branch October 17, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants